Fix Windows CI #147
Merged
Fix Windows CI #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhmerov
reviewed
Aug 9, 2020
|
I see the failures in Python 3.5. It's at its EoL in September, so I think we should drop it. |
I think they could be genuine fails on Linux paths - I'd only tested locally on Windows py3.8. Will look into it |
|
Fixed a couple of other bugs I'd created, but this passes on Ubuntu py3.6. @akhmerov are we able to trigger the other CI checks to double check this, before we drop 3.5? |
|
It's annoying since the jobs get canceled as soon as one fails. Yet, 3.7 and 3.8 work, and I think so should 3.6. |
|
So I'd say let's go and drop 3.5. |
akhmerov
requested changes
Aug 9, 2020
Co-authored-by: Anton Akhmerov <anton.akhmerov@gmail.com>
…yter-sphinx into fix/143/windows-ci
Co-authored-by: Anton Akhmerov <anton.akhmerov@gmail.com>
akhmerov
approved these changes
Aug 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-posix paths are causing CI to fail on Windows. Converted to posix
sphinx_abs_dirtries to get the relative path between two Windows drives when testing. Changed to use absolute path on Windowstests check that
sphinx_abs_diroutput is relative path usingassert_node. Updatedtest_download_roleto check if Windows absolute path is equivalent to the relative reftarget.Fixes #143, fixes #54
Should fix some issues in Windows tests at executablebooks/jupyter-book#723