Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften and suppress warnings about sticky bits #286

Merged
merged 2 commits into from Aug 10, 2017

Conversation

@minrk
Copy link
Member

minrk commented Aug 9, 2017

  • specifically silence EPERM on the containing directory,
    which can happen when using tempfiles.
  • when warning is triggered, explain that it's not a big deal and what might happen.

and actually set the sticky bit, which I just realized we weren't doing because I used the wrong variable to update the permissions.

cf discussion in #201

cc @takluyver @AlJohri

minrk added 2 commits Aug 9, 2017
use new_permissions, not old!
may not be permitted when using temporary files on some platforms

and soften warning, explaining consequences.
@takluyver takluyver added this to the 5.2 milestone Aug 10, 2017
@takluyver takluyver merged commit 1c506c0 into jupyter:master Aug 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AlJohri

This comment has been minimized.

Copy link

AlJohri commented Dec 27, 2017

thanks y'all! just wanted to check if this is already released - just ran into this issue on 5.3.1

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 3, 2018

It should be - you can see the milestone is set to 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.