Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make KernelRestarter class configurable. #290

Merged
merged 1 commit into from Aug 27, 2017

Conversation

@ssanderson
Copy link
Contributor

ssanderson commented Aug 26, 2017

Make the KernelRestarter class used by IOLoopKernelManager configurable.

@ssanderson

This comment has been minimized.

Copy link
Contributor Author

ssanderson commented Aug 26, 2017

xref: #186

@ssanderson

This comment has been minimized.

Copy link
Contributor Author

ssanderson commented Aug 26, 2017

@minrk do you think there would be interest in taking the throttling-based restart implementation posted at #186 (comment), either as a replacement for or an alternative to the current N-consecutive-attempts implementation?

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Aug 27, 2017

@ssanderson as discussed in person: yes, I think the restarted-budget logic you mentioned makes sense to bring in as the default behavior.

@minrk minrk merged commit f6bc5e6 into jupyter:master Aug 27, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk minrk added this to the 5.2 milestone Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.