Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for tornado 5 #304

Merged
merged 2 commits into from Nov 13, 2017

Conversation

@minrk
Copy link
Member

minrk commented Nov 10, 2017

  • use IOLoop.current over IOLoop.instance
  • drop removed loop arg from PeriodicCallback
  • deprecate now-unused IOLoopKernelRestarter.loop

pyzmq 17 will be needed to be fully compatible with tornado 5, which runs on asyncio on Python 3.

- use IOLoop.current over IOLoop.instance
- drop removed `loop` arg from PeriodicCallback
- deprecate now-unused IOLoopKernelRestarter.loop
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 10, 2017

Test failure in test_tracking.

@takluyver takluyver added this to the 5.2 milestone Nov 13, 2017
@takluyver takluyver merged commit 7a0278a into jupyter:master Nov 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk minrk deleted the minrk:tornado-5 branch Nov 13, 2017
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 15, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request Dec 15, 2017
takluyver added a commit that referenced this pull request Dec 15, 2017
Backport PR #304 on branch 5.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.