Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend special handling of sys.executable to pythonX[.Y] #306

Merged
merged 1 commit into from Dec 13, 2017

Conversation

@minrk
Copy link
Member

minrk commented Nov 22, 2017

this should allow ipykernel's wheel-installed specs to specify python3 or python2 and prevent python2 kernels from launching with sys.executable if the Python version is 3.

The new KernelFinder machinery may make this obsolete, but I think we still need this for ipykernel's wheels to avoid launching with sys.executable.

this should allow ipykernel's wheel-installed specs to specify `python3` or `python2` and prevent
python2 kernels from launching with sys.executable if the Python version is 3.
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Nov 22, 2017

Yup, I think this makes sense.

Do you want anyone specific to consider this before we merge? I'm happy to press the button.

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Dec 4, 2017

I think this is pretty straightforward, so I'm happy as-is. The release process is the trickier part - what version of jupyter-client this goes in (since you are working on big 6.0 things right now), when to adopt it in ipykernel, etc.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 13, 2017

I think the big changes are still likely to take a while to settle, so it's worth doing a 5.2 release with this and other improvements. I might make a 5.x branch and back out the new discovery machinery, since that's part of the big changes I'm still working on.

@takluyver takluyver added this to the 5.2 milestone Dec 13, 2017
@takluyver takluyver merged commit 16d8122 into jupyter:master Dec 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 15, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request Dec 15, 2017
takluyver added a commit that referenced this pull request Dec 15, 2017
Backport PR #306 on branch 5.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.