Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of get_kernel_spec #311

merged 1 commit into from Dec 15, 2017


Copy link

takluyver commented Dec 15, 2017

This avoids doing a full scan of kernel specs each time get_kernel_spec() is called. It only looks for the resource directory it needs, saving some unnecessary stat calls.

A caching solution could improve performance even more, but would be much more complex - this collects the low-hanging fruit.

@takluyver takluyver added this to the 5.2 milestone Dec 15, 2017
@Carreau Carreau merged commit adb8335 into jupyter:master Dec 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
meeseeksdev bot pushed a commit that referenced this pull request Dec 15, 2017
Carreau added a commit that referenced this pull request Dec 15, 2017
Backport PR #311 on branch 5.x
takluyver added a commit to takluyver/jupyter_client that referenced this pull request Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.