Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill process group when killing kernel #314

Merged
merged 1 commit into from Dec 15, 2017

Conversation

@minrk
Copy link
Member

minrk commented Dec 15, 2017

if killpg is available. Keeps kill_kernel consistent with other signals.

This should cleanup process groups (e.g. multiprocessing subprocesses) and make EADDRINUSE less likely during restart (ipython/ipykernel#274)
when kernels don't cleanup after themselves (ipykernel#290).

if killpg is available

this should cleanup process trees (e.g. multiprocessing subprocesses)
and make EADDRINUSE less likely during restart.
@takluyver takluyver merged commit 98a4323 into jupyter:master Dec 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Dec 15, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request Dec 15, 2017
takluyver added a commit that referenced this pull request Dec 15, 2017
Backport PR #314 on branch 5.x
takluyver added a commit to takluyver/jupyter_client that referenced this pull request Dec 15, 2017
basnijholt added a commit to python-adaptive/adaptive that referenced this pull request Feb 15, 2018
See the following issues / MR:
- ipython/ipykernel#274
- ipython/ipykernel#263
- jupyter/jupyter_client#314

ttps://github.com/jupyter/jupyter_client/pull/314# Please enter the commit message for your changes. Lines starting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.