Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parenthesize conditional requirement in setup.py #325

Merged
merged 1 commit into from Jan 2, 2018

Conversation

@Carreau
Copy link
Contributor

Carreau commented Dec 30, 2017

Du to a likely bug in wheel, the conditional dependency on pytest ends
up being unconditional. Seem like adding parenthesis fix that (as a work
around).

See pypa/setuptools#1242
Closes #324

@Carreau Carreau added this to the 5.2.1 milestone Dec 30, 2017
@Carreau

This comment has been minimized.

Copy link
Contributor Author

Carreau commented Dec 30, 2017

I've create a 5.2.x branch (from 5.2.0, please verify), created a 5.2.1 milestone and configured it (see milestone description) to ask MrMeeseeks to backport to 5.2.x on merge.

Du to a likely bug in wheel, the conditional dependency on pytest ends
up being unconditional. Seem like adding parenthesis fix that (as a work
around).

See pypa/setuptools#1242
Closes #324
@Carreau Carreau force-pushed the Carreau:fix-324 branch from 446ab64 to 072a087 Dec 30, 2017
@minrk minrk merged commit c85f8ac into jupyter:master Jan 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
meeseeksdev bot pushed a commit that referenced this pull request Jan 2, 2018
minrk added a commit that referenced this pull request Jan 2, 2018
Backport PR #325 on branch 5.2.x
@Carreau Carreau deleted the Carreau:fix-324 branch Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.