Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid calling private method in subclasses of KernelSpecManager #339

Merged
merged 2 commits into from Jan 23, 2018

Conversation

@minrk
Copy link
Member

minrk commented Jan 23, 2018

on the result of a public overrideable method, which breaks subclasses that don't override get_all_specs

rather than falling back on the public method, which is slower because it looks up the location of a directory we have already found, reserve this optimization for the base class itself, which is the only place this is a safe method to call.

closes #338

I think we should ship a 5.2.2 bugfix upon merging this one and confirming it fixes nb_conda_kernels

minrk added 2 commits Jan 23, 2018
on the result of a public overrideable method,
which breaks subclasses that don't override get_all_specs
@minrk minrk changed the title [WIP] avoid calling private method in subclasses of KernelSpecManager avoid calling private method in subclasses of KernelSpecManager Jan 23, 2018
@minrk minrk added this to the 5.2.2 milestone Jan 23, 2018
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jan 23, 2018

Thanks for tracking this down!

@takluyver takluyver merged commit 07d02be into jupyter:master Jan 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
meeseeksdev bot pushed a commit that referenced this pull request Jan 23, 2018
takluyver added a commit that referenced this pull request Jan 23, 2018
Backport PR #339 on branch 5.x
@minrk minrk deleted the minrk:fix-backward-incompat branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.