Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return None kernel_spec if kernel_name not set #344

Merged
merged 1 commit into from Feb 6, 2018

Conversation

@rgbkrk
Copy link
Member

rgbkrk commented Jan 27, 2018

This restores the ability of using the deprecated kernel_cmd, which previously allowed you to run an arbitrary kernel without having to write a kernelspec. Without this, when using kernel_cmd, a lookup on an empty kernel_name (with "" as value) was being performed.

@rgbkrk rgbkrk requested a review from takluyver Jan 27, 2018
@takluyver takluyver added this to the 5.3 milestone Feb 6, 2018
@takluyver takluyver merged commit 37d1104 into jupyter:5.x Feb 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 6, 2018

Thanks!

@rgbkrk rgbkrk deleted the rgbkrk:allow-none-kernelspec branch Feb 6, 2018
@minrk minrk modified the milestones: 5.3, 5.2.3 Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.