Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make closing jupyter client faster #420

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@impact27
Copy link
Contributor

impact27 commented Feb 11, 2019

When calling stop on a HBChannel, one has to wait until the sleep command ends. This would allow a much faster shutdown time.

@ccordoba12

This comment has been minimized.

Copy link
Contributor

ccordoba12 commented Feb 11, 2019

@minrk, @takluyver, we need this in Spyder because we set a very long time_to_dead time for the heartbeat channel to avoid too many empty prompts in qtconsole when the kernel takes too much time to start (which is a common problem for us, specially on Windows).

Thanks for your help!

@minrk minrk closed this Feb 15, 2019
@minrk minrk reopened this Feb 15, 2019
@minrk

This comment has been minimized.

Copy link
Member

minrk commented Feb 15, 2019

closing and reopening to retrigger tests. 👍 from me.

@minrk minrk added this to the 5.2.5 milestone Feb 15, 2019
@minrk minrk merged commit e813086 into jupyter:master Feb 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
meeseeksmachine pushed a commit to meeseeksmachine/jupyter_client that referenced this pull request Feb 15, 2019
@ccordoba12

This comment has been minimized.

Copy link
Contributor

ccordoba12 commented Feb 15, 2019

Thanks a lot Min!

minrk added a commit that referenced this pull request Mar 5, 2019
…on-5.x

Backport PR #420 on branch 5.x (Make closing jupyter client faster)
@impact27 impact27 referenced this pull request Aug 26, 2019
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.