Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes control channel in public API #447

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@JohanMabille
Copy link
Member

JohanMabille commented Jun 12, 2019

This PR exposes the control channel in the public API, as required in #446. The KernelClient has not been updated to connect to the Control socket, it might be interesting to do it later.

EDIT: additional changes might be required in KernelManagerto avoid having another socket trying to connect on the Control channel, but this is not clear to me for now.

@rgbkrk
rgbkrk approved these changes Jun 26, 2019
Copy link
Member

rgbkrk left a comment

Smart, we definitely need this.

@@ -14,6 +14,7 @@ __pycache__
.coverage
.cache
absolute.json
*.swp

This comment has been minimized.

Copy link
@rgbkrk

rgbkrk Jun 26, 2019

Member

This shouldn't have been added as part of this PR, but it's fine for now. I recommend adding vim swap files to your global gitignore so this doesn't come up for you in future repositories.

This comment has been minimized.

Copy link
@JohanMabille

JohanMabille Jun 26, 2019

Author Member

Thanks for pointing this out, to be honest I wasn't aware of this feature! I can make a PR to revert this change if you want.

This comment has been minimized.

Copy link
@rgbkrk

rgbkrk Jun 26, 2019

Member

I think it's ok for the moment as it won't hurt anything.

@rgbkrk rgbkrk merged commit 51d1d7a into jupyter:master Jun 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jtpio jtpio referenced this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.