Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure write for connection file #469

Merged
merged 5 commits into from Sep 8, 2019

Conversation

@MSeal
Copy link
Collaborator

MSeal commented Aug 19, 2019

Includes release information, as we should follow the merge directly with a patch release for 5.3.2.

@MSeal MSeal requested review from minrk, Carreau and SylvainCorlay Aug 19, 2019
@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Aug 19, 2019

I did some python 2 / 3 testing with downstream libraries as well and didn't run into any issues.

@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Aug 28, 2019

@minrk @Carreau @SylvainCorlay The same change is now merged in jupyter/jupyter_server#77 if one of you could help review

@rgbkrk
rgbkrk approved these changes Sep 8, 2019
@rgbkrk rgbkrk merged commit 8ea279b into 5.x Sep 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rgbkrk rgbkrk deleted the secureWriteCon branch Sep 8, 2019
@vidartf

This comment has been minimized.

Copy link

vidartf commented Sep 24, 2019

It seems the added dependency from this PR did not make it into the conda forge package, jupyterlab/jupyterlab#7259 . I'll create an issue on https://github.com/conda-forge/jupyter_client-feedstock to track this.

@vidartf vidartf referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.