Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure core import #483

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@MSeal
Copy link
Collaborator

MSeal commented Sep 30, 2019

Bug fixes for windows issues are going into jupyter_core for secure_write -- we can move to depending on that location to pick up fixes.

@kevin-bates We can bump the setup requirement to 4.5.1 once jupyter/jupyter_core#166 merges and releases.

@MSeal MSeal requested review from minrk and rgbkrk Sep 30, 2019
Copy link
Member

kevin-bates left a comment

Looks good - just had the comment about jupyter_core 4.6.0.

setup.py Outdated
@@ -88,7 +88,7 @@ def run(self):
],
install_requires = [
'traitlets',
'jupyter_core',
'jupyter_core>=4.5.0',

This comment has been minimized.

Copy link
@kevin-bates

kevin-bates Sep 30, 2019

Member

Since we're already building a 4.6.0 jupyter_core release - which is waiting on the final resolution for secure_write, I think we should just move to 4.6.0 with this change.

@kevin-bates

This comment has been minimized.

Copy link
Member

kevin-bates commented Oct 8, 2019

Now that core is at 4.6.0, it seems like we should pump out a jupyter_client release that depends on 4.6.0. Then, I believe many of the Windows issues should be resolved - although there's something fishing about the pywin32==225 release going on.

cc: @MSeal, @minrk, @rgbkrk

@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Oct 8, 2019

@kevin-bates the pywin32==225 build sounds like exclusively an anaconda build issue where the recipe is doing bad things. I've opened an issue in conda-forge/pywin32-feedstock#18 and linked to the thread in winpy32

@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Oct 8, 2019

Gonna merge and release to get this fixed

@MSeal MSeal merged commit ae1021e into 5.x Oct 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Oct 8, 2019

5.3.4 released!

@vidartf

This comment has been minimized.

Copy link

vidartf commented Oct 9, 2019

Does this mean that the "pywin32 >=1.0 ; sys_platform == 'win32'" dependency can be removed, and the conda forge package moved back to noarch?

@kevin-bates

This comment has been minimized.

Copy link
Member

kevin-bates commented Oct 9, 2019

@MSeal - thank you! That's actually great new about pywin32==225.

Since there's a NB patch release brewin', does it make sense to bump the min versions of core and client to 4.6.0 and 5.3.4, respectively? I'm happy to submit that PR if you agree.

What is the timeframe to get secure_write into client/master?

@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Oct 9, 2019

@vidartf Yes, assuming the dependency being arch specific doesn't force the downstream package to do so (don't think it does). If you want to make the PR I can help get that merged.

@kevin-bates +1.

@rgbkrk rgbkrk deleted the secureCore branch Oct 9, 2019
vidartf added a commit to vidartf/jupyter_client that referenced this pull request Oct 9, 2019
Its use was removed in jupyter#483, so we can drop it now.
@vidartf vidartf referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.