Layout fixes for tab bar and tab stack panel #770
Conversation
|
I should mention that I have a lot more work like this on the way... Here is a screenshot of what this looks like:
|
| .p-TabBar { | ||
| overflow: visible; | ||
| color: #777777; | ||
| font-size: 13px; | ||
| font-size: @jp-ui-font-size; |
There was a problem hiding this comment.
Should we follow our CSS naming convention and use jp-ui-fontSize here?
There was a problem hiding this comment.
Thought about that - the main difference is that things like font-size are actual CSS properties. Many/most of our less variables will have names like @jp-component-css-property so I would prefer to use a slightly modified naming convention here.
|
Should this explicitly close #680? |
|
This should not close #680 as there are a bunch of other things I need to fix as well... |
|
@blink1073 once this has passed Travis again, this should be ready for merge. See above note about less variable names. |
|
Merging to keep iterating... |
lock
bot
added
the
status:resolved-locked
This brings up the core layout of the dock area to where it was before the mono-repo. I am also using less to better parametrize the border/width/height of the tabs.