Skip to content

Commit

Permalink
Allow access from remote hosts
Browse files Browse the repository at this point in the history
A recent change to Notebook (5.6.0) prevents access from remote hosts by default.
This change unconditionally re-enables that ability since remote access is a primary
tenet of Kernel Gateway.

Also dropped python 3.3 from the travis matrix since setuptools no longer supports
it (as of May 24) and was generating a failure during the installation phase.

Fixes #293
  • Loading branch information
kevin-bates committed Jul 17, 2018
1 parent cc3f0f7 commit 97c13e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Expand Up @@ -2,7 +2,6 @@ sudo: false
language: python
python:
- 2.7
- 3.3
- 3.4
- 3.5
- 3.6
Expand Down
4 changes: 3 additions & 1 deletion kernel_gateway/gatewayapp.py
Expand Up @@ -457,7 +457,9 @@ def init_webapp(self):
kg_personality=self.personality,
# Also set the allow_origin setting used by notebook so that the
# check_origin method used everywhere respects the value
allow_origin=self.allow_origin
allow_origin=self.allow_origin,
# Always allow remote access (has been limited to localhost >= notebook 5.6)
allow_remote_access=True
)

# promote the current personality's "config" tagged traitlet values to webapp settings
Expand Down

0 comments on commit 97c13e1

Please sign in to comment.