Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export_from_notebook names #1001

Merged
merged 1 commit into from Apr 25, 2019
Merged

fix export_from_notebook names #1001

merged 1 commit into from Apr 25, 2019

Conversation

@t-makaro
Copy link
Collaborator

t-makaro commented Apr 25, 2019

When looking at #938, I noticed that the template exporter has export_from_notebook defined which means it appears in the notebook's download as menu, and the html exporter was inheriting this.

@t-makaro t-makaro mentioned this pull request Apr 25, 2019
@t-makaro

This comment has been minimized.

Copy link
Collaborator Author

t-makaro commented Apr 25, 2019

I don't know why the test failed. Only one test failed on only one version of python, and it seems unrelated to my change. It also passes on my machine with python 3.6.

@MSeal

This comment has been minimized.

Copy link
Collaborator

MSeal commented Apr 25, 2019

Test failure was a red harring. I tried a few conversion options and checked that nothing obvious was affected. I'll plop this in the release so the notebooks PR can merge post release.

@MSeal MSeal merged commit b8f2062 into jupyter:master Apr 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MSeal MSeal added this to the 5.5 milestone Apr 25, 2019
@t-makaro t-makaro deleted the t-makaro:exportnames branch Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.