Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Use conda root environment, no need to "activate" #1120

Merged
merged 1 commit into from Oct 21, 2019

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Oct 19, 2019

I didn't like having to call "activate" before each step in my original setup (see #1114).

By installing everything in the "root" environment, we can avoid this.
We also have to save the conda paths etc. in BASH_ENV, for them to be made available in each new task.

@mgeier
Copy link
Contributor Author

mgeier commented Oct 19, 2019

That's the CircleCI log: https://app.circleci.com/jobs/github/mgeier/nbconvert/36

@MSeal
Copy link
Collaborator

MSeal commented Oct 21, 2019

Running CI tooling as root is generally best avoided if possible, but since the conda env is already owned by root I don't see a problem changing it. Probably better long-term to use a localized environment for the user running the tests, but I'll merge it for now.

@MSeal MSeal merged commit cda5ec4 into jupyter:master Oct 21, 2019
@mgeier
Copy link
Contributor Author

mgeier commented Oct 21, 2019

Thanks for merging!

TBH, I don't know whether and how I can change the user. I guess that depends on the used image, right?

I didn't think about changing the user and I didn't notice anyone changing the user in the examples I was consulting.

If you think pursuing this path further is worthwhile please let me know.

@mgeier mgeier deleted the circleci-without-activate branch October 21, 2019 21:07
@MSeal
Copy link
Collaborator

MSeal commented Oct 21, 2019

Nah don't worry about it for now. If we get warnings on our builds then we should go take a look again later.

@MSeal MSeal added this to the 5.6.1 milestone Oct 21, 2019
@MSeal MSeal added this to the 5.6.1 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants