Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state filter #1664

merged 3 commits into from Oct 28, 2021


Copy link


In #1643, the WidgetsDataTypeFilter is updated to filter out the widgets without the state. To make it works, WidgetsDataTypeFilter needs to have access to the notebook's metadata which is only available after instantiating the filter itself. This situation leads to a widget rendering issue if nbconvert needs to execute the notebook before converting it.

Code changes

This PR updates the logic of getting the notebook's metadata inside WidgetsDataTypeFilter and adds some tests for the case of executing the notebook before converting.

Copy link

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link

This looks good to me. Should we go ahead and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants