/ nbconvert Public
Optionally speed up validation #1672
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
In our flamegraph research we found that as much as 90% of the time spent in
Notebook creation can occur in the preprocessor valdiation logic. This pr
introduces the optional idea of optimistic validation, in which we care not
about which preprocessor introduces a validation error but that the notebook
ends in a valid state, since we care more about speed.
this logic, or the best way to structure such a test. If a reference
is available I will happily added a test.