Add an invalid notebook error #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
- As we are now service hundreds of thousands of notebooks a day, we are
seeing a number of errors from Notebook rendering that really stem
from notebooks not being properly formated. These show up in a number
of errors such as the error handled in this pr, an assertion error,
we have also seen key errors and others. This pr is a bit of a proposal
to instead introduced a common exception that indicates the notebook
is missing some required data that is needed to render itself.
|
I would be happy to have a common exception with subclasses, that seem like a reasonable requests. |
Carreau
reviewed
Dec 10, 2021
For other readers "We" in this context is GitHub themselves. Sorry for the delay in responding, the jupyter team is quite thin, and we don't always watch all the repos. |
Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
|
Thank you @Carreau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation:
seeing a number of errors from Notebook rendering that really stem
from notebooks not being properly formatted. These show up in a number
of errors such as the error handled in this pr, an assertion error,
we have also seen key errors and others. This pr is a bit of a proposal
to instead introduced a common exception that indicates the notebook
is missing some required data that is needed to render itself.