New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to tests by having them in the example notebook #505

Merged
merged 2 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@mpacer
Copy link
Member

mpacer commented Jan 4, 2017

I noticed none of the link code included in #458 was being tested.

Figured I'd preëmptively include links for both pandoc compatible and incompatible automatic header-id generation.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jan 4, 2017

Ok I think this is breaking because travis is using the older version of pandoc as installed https://github.com/jupyter/nbconvert/blob/master/.travis.yml#L30, we should update it since it's on version 1.15.1 and the most recent pandoc version is 1.19.1.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jan 4, 2017

Right now I'm running into issues that I cannot reproduce locally. They seem to be related to finding pandoc after it is unzipped, since the pandoc command is not found. My guess is that this has to do with the way that we were unpacking it before (using what I think is a rackspace cdn), which isn't the standard installation procedure (at least in terms of the link given in the pandoc docs).

I'm going to figure out how to build travis locally and then will take a crack at debugging it more directly.

@mpacer mpacer force-pushed the mpacer:test_links branch from 72879ac to b4e41a3 Jan 4, 2017

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jan 4, 2017

@Carreau | @minrk | @takluyver Can I get an external review? I figure the only thing that could be in disagreement about this is shifting to pandoc's newest version, with the API against which we've been writing code.

Note: our current code fails when using the old API (since travis is using pandoc v1.15, just including the links in the example notebook causes failures).

@takluyver takluyver merged commit 0097e82 into jupyter:master Jan 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver added this to the 5.1 milestone Jan 6, 2017

@mpacer mpacer added unlogged and removed unlogged labels Jan 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment