New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax help output check #516

Merged
merged 1 commit into from Jan 20, 2017

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Jan 20, 2017

Traitlets has changed the format of help output slightly; this doesn't atter for nbconvert, so relax the check.

Similar to ipython/ipython#10156

Relax help output check
Traitlets has changed the format of help output slightly; this doesn't
matter for nbconvert, so relax the check.

Similar to ipython/ipython#10156

@takluyver takluyver added this to the 5.1 milestone Jan 20, 2017

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Jan 20, 2017

LGTM. I'm curious, what is driving these changes to traitlets? If you know where they are off the top of your head, could you link to the PRs?

@mpacer mpacer merged commit c3675fe into jupyter:master Jan 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk

This comment has been minimized.

Copy link
Member

minrk commented Jan 20, 2017

Prompted by ipython/traitlets#354, which was some formatting cleanup for help output.

@mpacer mpacer added unlogged and removed unlogged labels Jan 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment