New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytest.mark.parameterize not yield tests from nose #519

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
3 participants
@mpacer
Copy link
Member

mpacer commented Jan 23, 2017

Got tired of the deprecation warnings, and after a little bit of looking into it, it wasn't too hard to fix.

In fact the @pytest.mark.parametrize decorator may be useful in other contexts (now that I know how it works).

But this is all I'm going to do in this pr.

@willingc

This comment has been minimized.

Copy link
Member

willingc commented Jan 23, 2017

Yay test enhancements! Ran fine locally and is passing here. Thanks @michaelpacer ☀️

@willingc willingc merged commit 605bac3 into jupyter:master Jan 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk added this to the 5.2 milestone Mar 27, 2017

@mpacer mpacer added to_changelog and removed to_changelog labels May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment