New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute needs at least jupyter_client 4.2 #539

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@Carreau
Copy link
Contributor

Carreau commented Feb 27, 2017

wait_for_ready()'s timeout option was added in 4.2 and previous
versions complain as they don't expect extra arguments.

cc @michaelpacer

Execute needs at least jupyter_client 4.2
`wait_for_ready()`'s `timeout` option was added in 4.2 and previous
versions complain as they don't expect extra arguments.
@Carreau

This comment has been minimized.

Copy link
Contributor Author

Carreau commented Feb 27, 2017

6.0 or 5.2 ?

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Feb 27, 2017

5.2, we've got a ways to go before 6.0.

LGTM merging.

@mpacer mpacer added this to the 5.2 milestone Feb 27, 2017

@mpacer mpacer merged commit f9b00e3 into jupyter:master Feb 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Copy link
Contributor Author

Carreau commented Feb 27, 2017

@meeseeksdev backport

@Carreau

This comment has been minimized.

Copy link
Contributor Author

Carreau commented Feb 27, 2017

@meeseeksdev backport

D'oh, master is 5.x .. sorry tired today.

@mpacer mpacer added to_changelog and removed to_changelog labels May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment