New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the slide exporter a little more configurable #542

Merged
merged 2 commits into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@yuvipanda
Copy link
Member

yuvipanda commented Mar 5, 2017

  • Allow configuring which theme to use for reveal.js
  • Allow configuring where to load jQuery / require_js / font-awesome from (same reason as #315)
  • Move default for loading font-awesome to cdnjs to match default for other URLs

yuvipanda added some commits Mar 5, 2017

Allos customizing where slide js / css is loaded from
Some installations (such as Wikimedia) prohibit usage of external
CDNs for privacy reasons, and this allows them to continue using
nbconvert.

I also got font-awesome from cdnjs as well, since that's where
the other defaults were pointing to.
@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Mar 6, 2017

This lgtm.

@mpacer mpacer merged commit a868ee1 into jupyter:master Mar 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minrk minrk added this to the 5.2 milestone Mar 27, 2017

@mpacer mpacer added to_changelog and removed to_changelog labels May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment