New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing default values correctly, otherwise they are all empty. #558

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@damianavila
Copy link
Member

damianavila commented Mar 26, 2017

Fixes #557

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Mar 27, 2017

Based on this https://github.com/ipython/traitlets/blob/master/traitlets/traitlets.py#L489 I think it might have needed to be default_value rather than default but this should work too.

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Mar 27, 2017

Merging

@mpacer mpacer merged commit 2549ece into jupyter:master Mar 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@damianavila damianavila deleted the damianavila:fix_slides_defaults branch Mar 28, 2017

@damianavila

This comment has been minimized.

Copy link
Member Author

damianavila commented Mar 28, 2017

Based on this https://github.com/ipython/traitlets/blob/master/traitlets/traitlets.py#L489 I think it might have needed to be default_value rather than default but this should work too.

Nice to know.

Merging

Thank you!

@mpacer mpacer added this to the 5.2 milestone May 24, 2017

@mpacer mpacer added to_changelog and removed to_changelog labels May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment