New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup_timeout configurable to execute preprocessor #583

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
3 participants
@parente
Copy link
Member

parente commented May 8, 2017

The execute preprocessor has a hardcoded 60 second timeout for a kernel to report that it is ready. In a busy environment or underpowered machine, a longer time is sometimes needed. This PR makes it configurable by the user but keeps the default of 60s.

@@ -202,14 +212,13 @@ def preprocess(self, nb, resources):

# from jupyter_client.manager import start_new_kernel

def start_new_kernel(startup_timeout=60, kernel_name='python',

This comment has been minimized.

@takluyver

takluyver May 8, 2017

Member

I think the intention of this function is that at some point it can be replaced with the jupyter_client import above. So let's leave this as is, and pass in startup_timeout where it's called a few lines below.

This comment has been minimized.

@parente

parente May 8, 2017

Author Member

Changed as requested.

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented May 8, 2017

lgtm merging.

@mpacer mpacer merged commit 0352919 into jupyter:master May 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpacer mpacer added this to the 5.2 milestone May 24, 2017

@mpacer mpacer added to_changelog and removed to_changelog labels May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment