Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update reveal, fix scrolling and add transition option #600
This was referenced
May 31, 2017
mpacer left a comment
Overall this seems solid. I'm not the most familiar with reveal and how to make it play nicely with css.
What I don't understand is why we need to do this kind of custom scrolling in the first place. What is it about our stuff is breaking the standard scroll?
People using nbconverted slides wanted from the very beginning to have scrolling slides. And we provide that even when reveal.js itself discouraged any use of scrolling inside the slides. As a consequence, in repetitive cases, the scrolling stuff broke. In this PR I am trying to make the scrolling stuff just a configurable thing and if the user really wanted, they can have it.
You have here more stuff on the scrolling discussion if you are interested: #78