Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove, normalise mathjax handling, yapf the file #609
Conversation
mpacer
added some commits
Jun 23, 2017
This comment has been minimized.
This comment has been minimized.
Does anyone have any issues with this PR? Or can I merge? |
This comment has been minimized.
This comment has been minimized.
For the future, I'd suggest keeping functional changes separate from code formatting, because it's harder to review changes to the code if they're mixed with changes to the style. As this is already here, though, go for it. (We've also mostly discouraged large formatting changes, because the changes make things like git blame less useful. But as you're doing most of the work on nbconvert at the moment, I think you get to decide things like that) |
This comment has been minimized.
This comment has been minimized.
@mpacer will take a look at this! |
This comment has been minimized.
This comment has been minimized.
takluyver
merged commit e5ba024
into
jupyter:master
Jul 27, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
mpacer
modified the milestone:
5.3
Aug 1, 2017
mpacer
added
unlogged
and removed
unlogged
labels
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mpacer commentedJun 23, 2017
Closes #544.