New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve, normalise mathjax handling, yapf the file #609

Merged
merged 5 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@mpacer
Copy link
Member

mpacer commented Jun 23, 2017

Closes #544.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jul 19, 2017

Does anyone have any issues with this PR? Or can I merge?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jul 20, 2017

For the future, I'd suggest keeping functional changes separate from code formatting, because it's harder to review changes to the code if they're mixed with changes to the style. As this is already here, though, go for it.

(We've also mostly discouraged large formatting changes, because the changes make things like git blame less useful. But as you're doing most of the work on nbconvert at the moment, I think you get to decide things like that)

@bollwyvl

This comment has been minimized.

Copy link
Contributor

bollwyvl commented Jul 25, 2017

@mpacer will take a look at this!

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jul 25, 2017

This is not likely to be problematic. It just aims to match the notebook in terms of its functionality; but always happy to have more review.

@bollwyvl I meant #611 was what needed testing since it's technically removing the functionality whereas this is more adding functionality.

@takluyver takluyver merged commit e5ba024 into jupyter:master Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpacer mpacer modified the milestone: 5.3 Aug 1, 2017

@mpacer mpacer added unlogged and removed unlogged labels Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment