# Transforms all mistune mathjax logic to be inline #611

Merged
merged 8 commits into from Aug 8, 2017

## Conversation

Projects
None yet
2 participants
Member

### mpacer commented Jun 23, 2017

 This is substantially less complicated in terms of the underlying logic doing the parsing. That said, I'm not sure we're testing all of the ways that this could cause things to break. But, if this did cause breakage, my guess is it would teach us what tests we should have. Also, it avoids the inelegance of the previous simultaneous inline-block-math and block-block-math approach. Worth mentioning, if you look at the output text and had two block-block-math blocks back to back e.g.,  $$a + b$$ \$a +b\$  Way mistune does preprocessing would eat the whitespace between them and transform it into "

$$a+b$$$$a+b$$<\p>"  which would still be parsed correctly from mathjax's perspective, but it's more than a little weird if you look at the raw text directly.

### mpacer added some commits Jun 23, 2017

 Improve, normalise mathjax handling, yapf the file 
 5c2ae3a 
 add inline correction, use multiple groups everywhere, change propert… 
…y and function name
 ec9412c 
 make tests check for this, but now tests fail 
 4ce1989 
 partial yapf, remove \\( syntax from unchanged test 
 593ce62 
 now the filter tests this and it works 
 83cb693 
 Move everything inline 
 d4f8473 
 delete all of the commented out block code 
 4832585 
 Now that it's not used more than once no need for global re.compiles 
 6d5c899 
Member Author

### mpacer commented Jun 28, 2017

 Note while this deals with markdown & mathjax, it doesn't solve the probem for LaTeX, that should probably be a separate PR.
Member Author

### mpacer commented Jun 29, 2017

 NB: #617 deals with LaTeX output.
Member Author

### mpacer commented Jul 25, 2017

 @bollwyvl this is the one that i actually meant but the other one too!

Merged

### minrk merged commit 202be28 into jupyter:master Aug 8, 2017 1 check passed

#### 1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Open

Closed