New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforms all mistune mathjax logic to be inline #611

Merged
merged 8 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@mpacer
Copy link
Member

mpacer commented Jun 23, 2017

This is substantially less complicated in terms of the underlying logic doing the parsing.

That said, I'm not sure we're testing all of the ways that this could cause things to break. But, if this did cause breakage, my guess is it would teach us what tests we should have.

Also, it avoids the inelegance of the previous simultaneous inline-block-math and block-block-math approach.

Worth mentioning, if you look at the output text and had two block-block-math blocks back to back
e.g.,


$$a + b$$

\\[a +b\\]

Way mistune does preprocessing would eat the whitespace between them and transform it into

"<p>$$a+b$$$$a+b$$<\p>"

which would still be parsed correctly from mathjax's perspective, but it's more than a little weird if you look at the raw text directly.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jun 28, 2017

Note while this deals with markdown & mathjax, it doesn't solve the probem for LaTeX, that should probably be a separate PR.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jun 29, 2017

NB: #617 deals with LaTeX output.

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Jul 25, 2017

@bollwyvl this is the one that i actually meant but the other one too!

@minrk

minrk approved these changes Aug 1, 2017

@minrk minrk merged commit 202be28 into jupyter:master Aug 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpacer mpacer modified the milestone: 5.3 Aug 18, 2017

@mpacer mpacer added unlogged and removed unlogged labels Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment