New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check execute_reply for errors when executing cell #642

Merged
merged 2 commits into from Aug 7, 2017

Conversation

Projects
None yet
2 participants
@takluyver
Copy link
Member

takluyver commented Aug 7, 2017

Closes gh-641

This is needed for UsageErrors from IPython to be treated as an error by nbconvert.

@takluyver takluyver added this to the 5.3 milestone Aug 7, 2017

msg_id = self.kc.execute(cell.source)
self.log.debug("Executing cell:\n%s", cell.source)
exec_reply = self._wait_for_reply(msg_id, cell)
print(exec_reply)

This comment has been minimized.

@mpacer

mpacer Aug 7, 2017

Member

Why print here?

This comment has been minimized.

@takluyver

takluyver Aug 7, 2017

Author Member

'cause I'm a fool who leaves debugging statements in ;-)

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Aug 7, 2017

LGTM

@mpacer mpacer merged commit 8ee2194 into jupyter:master Aug 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpacer mpacer added unlogged and removed unlogged labels Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment