Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upif nb.metadata.title is set, default to that for notebook #672
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Carreau can I get a review? |
takluyver
added this to the 5.4 milestone
Sep 15, 2017
takluyver
merged commit 710548f
into
jupyter:master
Sep 15, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Looks fine to me. |
mpacer
referenced this pull request
Nov 13, 2017
Merged
Use "title" instead of "name" for metadata to match the notebook format #703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mpacer commentedSep 8, 2017
There is a title field in the notebook metadata as part of the nbformat v4 spec. We should use this feature if it is available.
This should solve #249.