New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if nb.metadata.title is set, default to that for notebook #672

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@mpacer
Copy link
Member

mpacer commented Sep 8, 2017

There is a title field in the notebook metadata as part of the nbformat v4 spec. We should use this feature if it is available.

This should solve #249.

@mpacer mpacer referenced this pull request Sep 8, 2017

Open

how to change pdf title #249

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Sep 13, 2017

@Carreau can I get a review?

@takluyver takluyver added this to the 5.4 milestone Sep 15, 2017

@takluyver takluyver merged commit 710548f into jupyter:master Sep 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Sep 15, 2017

Looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment