New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown block lexer/parser for LaTeX blocks #716

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@takluyver
Copy link
Member

takluyver commented Dec 6, 2017

Resurrection of PR #715, because I want to be able to easily compare it with @mpacer's proposal.

See #404 for rationale.

CC @danilobellini

Add Markdown block lexer/parser for LaTeX blocks
The block lexer/parser was splitting equations like this

$$
x
=
2
$$

So the inline lexer/parser was never seeing the whole equation, and
it wasn't getting properly rendered. This fixes such breaking by
adding a block-level lexer/parser to the LaTeX equations written as
either $$...$$ or \\[...\\]

The inline "block math" parsing code was kept as is, since the above
equation could have been part of a paragraph like "$$x = 2$$" to keep
the compatibility with Jupyter Notebook rendering engine (and because
there's a test enforcing that behavior)

@mpacer mpacer referenced this pull request Dec 6, 2017

Merged

Multiline math #717

@takluyver takluyver merged commit 1db9666 into jupyter:master Dec 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:pr715 branch Dec 12, 2017

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Dec 12, 2017

On the technical merits, it was a close call between this and #717, but I marginally preferred that one. It was based on this branch, however, so both pull requests now show as merged.

@mpacer mpacer added this to the 5.4 milestone Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment