Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix for an issue with empty math block #729
referenced this pull request
Jan 9, 2018
Ok, did a couple of quick tests to make sure that I was following this, we need the "" as a fallback in the case where either
Since it was first triggered by the grammar match, we don't have to worry about returning an empty string in an inappropriate context.
So we can safely always return a fallback empty string, and then if we pass the empty string, it should correctly be interpreted as
So, the question remains: why did your the test you introduced in 4f23786 fail — it should have been passed through without issue.
Ok, just double checked it; the issue with your initial commit was that you represented the multiline string as a single line. My guess is you were editing the file as a
Anyway I created an example of how a notebook's cell should be formatted to pass the tests based on just opening and saving the notebook you modified in 4f23786.
@mpacer Sorry, misunderstood your comment here #726 (comment) Thought it was about
@mpacer By "them" you mean "$$$$"?
Btw previous behaviour was