New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows unicode error fixed, nosetest added to setup.py #757

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
3 participants
@HagaiHargil
Copy link
Contributor

HagaiHargil commented Feb 7, 2018

@takluyver Your suggestion at #742 was spot on.

I've also added nose to the test dependencies, since running py.test --pyargs nbconvert doesn't work when nose isn't installed (seems like iPython has this dependency).

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 7, 2018

Thanks, the actual fix looks good to me, but it should be necessary to require nose for tests - PRs #595 and #660 got rid of the imports. What errors were you getting without nose?

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Feb 7, 2018

Apparently, we still have some imports inside the test_svg2pdf.py and test_io.py. I don't know how I missed those before since I was grepping for all instances of nose.

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Feb 7, 2018

ah… it's in the ipython_genutils decorators… hrm… I'll see if I can fix that.

@HagaiHargil

This comment has been minimized.

Copy link
Contributor Author

HagaiHargil commented Feb 7, 2018

Would you like me to resubmit the PR without the setup.py change? Or will you change it back in a later commit?

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Feb 7, 2018

I'd say we merge this and change it back when we can figure out the remaining nose dependencies. This is correct for now, after all. But I'll let @mpacer make the final call.

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Feb 7, 2018

Yea… I agree, though I really don't like having to add nose back even temporarily. :grumble:

merging.

@mpacer mpacer merged commit 06b5452 into jupyter:master Feb 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpacer mpacer added this to the 5.4 milestone Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment