Removing more nose remnants via dependencies. #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpacer
force-pushed
the
find_the_hidden_nose
branch
from
48bae7c
to
c0507cb
Compare
mpacer
force-pushed
the
find_the_hidden_nose
branch
from
c0507cb
to
9c3fc49
Compare
takluyver
reviewed
Feb 8, 2018
| @dec.onlyif_cmds_exist('xelatex') | ||
| @dec.onlyif_cmds_exist('pandoc') | ||
| @onlyif_cmds_exist('xelatex') | ||
| @onlyif_cmds_exist('pandoc') |
There was a problem hiding this comment.
This could be combined into one decorator, right?
nbconvert/tests/test_nbconvertapp.py
Outdated
| @dec.onlyif_cmds_exist('xelatex') | ||
| @dec.onlyif_cmds_exist('pandoc') | ||
| @onlyif_cmds_exist('xelatex') | ||
| @onlyif_cmds_exist('pandoc') |
There was a problem hiding this comment.
Combine (and another one just below)
nbconvert/tests/test_nbconvertapp.py
Outdated
| @dec.onlyif_cmds_exist('xelatex') | ||
| @dec.onlyif_cmds_exist('pandoc') | ||
| @onlyif_cmds_exist('xelatex') | ||
| @onlyif_cmds_exist('pandoc') |
|
Hooray for shrinking dependencies on genutils! |
minrk
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was revealed in #757 super helpfully by @HagaiHargil that we were implicitly relying on nose because we were using ipython_genutils test decorators.
This removes those
ipython_genutilsversions by porting the@onlyif_cmds_existdecorator and usingpytest.markinside of it instead of a bunch of differentnosebits.