New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing more nose remnants via dependencies. #758

Merged
merged 5 commits into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@mpacer
Copy link
Member

mpacer commented Feb 8, 2018

It was revealed in #757 super helpfully by @HagaiHargil that we were implicitly relying on nose because we were using ipython_genutils test decorators.

This removes those ipython_genutils versions by porting the @onlyif_cmds_exist decorator and using pytest.mark inside of it instead of a bunch of different nose bits.

@mpacer mpacer force-pushed the mpacer:find_the_hidden_nose branch from 48bae7c to c0507cb Feb 8, 2018

@mpacer mpacer force-pushed the mpacer:find_the_hidden_nose branch from c0507cb to 9c3fc49 Feb 8, 2018

@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
@onlyif_cmds_exist('xelatex')
@onlyif_cmds_exist('pandoc')

This comment has been minimized.

@takluyver

takluyver Feb 8, 2018

Member

This could be combined into one decorator, right?

This comment has been minimized.

@mpacer

mpacer Feb 8, 2018

Author Member

yep! good call!

@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
@onlyif_cmds_exist('xelatex')
@onlyif_cmds_exist('pandoc')

This comment has been minimized.

@takluyver

takluyver Feb 8, 2018

Member

Combine (and another one just below)

This comment has been minimized.

@mpacer

mpacer Feb 8, 2018

Author Member

yep! good call!

@dec.onlyif_cmds_exist('xelatex')
@dec.onlyif_cmds_exist('pandoc')
@onlyif_cmds_exist('xelatex')
@onlyif_cmds_exist('pandoc')

This comment has been minimized.

@takluyver

takluyver Feb 8, 2018

Member

Combine

This comment has been minimized.

@mpacer

mpacer Feb 8, 2018

Author Member

yep! good call!

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Feb 9, 2018

Hooray for shrinking dependencies on genutils!

@minrk

minrk approved these changes Feb 9, 2018

@takluyver takluyver added this to the 5.4 milestone Feb 9, 2018

@takluyver takluyver merged commit 626c82a into jupyter:master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment