New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle embedded images in html converter #780

Merged
merged 2 commits into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@scottdraves
Copy link

scottdraves commented Mar 18, 2018

No description provided.

@scottdraves scottdraves changed the title handling embeded images in html converter handle embeded images in html converter Mar 18, 2018

@scottdraves scottdraves changed the title handle embeded images in html converter handle embedded images in html converter Mar 18, 2018

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Mar 19, 2018

Can you write tests for this functionality? I think it will require adding a new notebook

@scottdraves

This comment has been minimized.

Copy link
Author

scottdraves commented Mar 29, 2018

@mpacer good to go?

@blink1073 blink1073 added this to the 5.4 milestone Aug 29, 2018

@blink1073

This comment has been minimized.

Copy link
Member

blink1073 commented Aug 29, 2018

Thanks!

@blink1073 blink1073 merged commit d3c91bb into jupyter:master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment