New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update font-awesome version for slides #793

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@kikocorreoso
Copy link

kikocorreoso commented Apr 5, 2018

Update font-awesome version when converting to slides in order to use that used by the notebook itself:
https://github.com/jupyter/notebook/blob/master/bower.json#L10

@minrk minrk added this to the 5.4 milestone Aug 16, 2018

@minrk minrk merged commit 9f1a2aa into jupyter:master Aug 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Sep 5, 2018

@kikocorreoso In the future can you include your github name in your metadata for committing? This allows us to automatically give you credit when we're making a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment