New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for too recent of pandoc version #814

Merged
merged 3 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@hfuhruhurr
Copy link
Contributor

hfuhruhurr commented May 16, 2018

In researching how I can contribute to #610 at the PyCon Sprints, I noticed 2 of the 9 tests in unmodified test_markdown.py failed.

@ivanov suggested I make a trivial change and submit a PR so the code would run through Travis to see if the failures are replicated.

@hfuhruhurr hfuhruhurr changed the title Trivial change to test tests Check for too recent of pandoc version May 16, 2018

@hfuhruhurr

This comment has been minimized.

Copy link
Contributor Author

hfuhruhurr commented May 16, 2018

My local tests were failing because my version of pandoc was too recent (2.2.1). Using 1.19.1 locally was met with success. The PR now incorporates logic to notify a user of an unsupported version of pandoc (if it's 2.0.0 or newer). This logic won't cause a failure; it will simply inform the user an unsupported version of pandoc is being used.

@ivanov

@ivanov

ivanov approved these changes May 16, 2018

Copy link
Member

ivanov left a comment

Looks good to me, just one last change to remove that original trivial change and this will be good to go!

@@ -1,3 +1,6 @@
# trivial line added to run travis on this file
# because, locally, 2 of the 9 tests fail

This comment has been minimized.

@ivanov

ivanov May 16, 2018

Member

Could we take this out?

@ivanov

This comment has been minimized.

Copy link
Member

ivanov commented May 16, 2018

Thanks for your contribution @hfuhrhurr ! Merging.

@ivanov ivanov merged commit d35c515 into jupyter:master May 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hfuhruhurr hfuhruhurr deleted the hfuhruhurr:testfails branch May 16, 2018

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Aug 31, 2018

Btw just as a heads up, this broke our docs by introducing an API incompatibility (max_ver shouldn't be a positional argument, but a keyword argument).

@mpacer mpacer referenced this pull request Aug 31, 2018

Merged

Fix api break #872

@mpacer mpacer added this to the 5.4 milestone Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment