New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move onlyif_cmds_exist decorator to test-specific utils #854

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Aug 7, 2018

Fixes #853

cc @Carreau @minrk

@Carreau

Carreau approved these changes Aug 7, 2018

Copy link
Contributor

Carreau left a comment

LGTM.

@Carreau Carreau requested a review from mpacer Aug 7, 2018

@SylvainCorlay

This comment has been minimized.

Copy link
Member Author

SylvainCorlay commented Aug 9, 2018

@Carreau that one is very mechanical and makes the master branch usable without pytest.

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Aug 9, 2018

@SylvainCorlay

This comment has been minimized.

Copy link
Member Author

SylvainCorlay commented Aug 9, 2018

That still move fonction import. So may be breaking API

This is moving something that was introduced after the last release.

@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Aug 9, 2018

This is moving something that was introduced after the last release.

Ok, that was one of the things I was going to check.

Merging then.

@Carreau Carreau merged commit 9f5c402 into jupyter:master Aug 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SylvainCorlay SylvainCorlay deleted the SylvainCorlay:pytest-deps branch Aug 10, 2018

@mpacer mpacer added this to the 5.4 milestone Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment