New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export_from_notebook #864

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@starcruiseromega
Copy link
Contributor

starcruiseromega commented Aug 25, 2018

I was working on jupyter/notebook#3879 and it
looks like the intended way to determine whether the exporter should
show up in the list generated by the notebook server was by checking
export_from_notebook, but it isn't defined for any of the builtin
exporters.

The docs also say this specifies a friendly name for the exporter. In
the PR mentioned above, I used the name defined by the entrypoint to key
the exporter. It sounds like maybe we should use the value in
export_from_notebook instead, so I've made them match, but perhaps
it's confusing to have a "name" for the entrypoint in two places.

Add export_from_notebook
I was working on jupyter/notebook#3879 and it
looks like the intended way to determine whether the exporter should
show up in the list generated by the notebook server was by checking
`export_from_notebook`, but it isn't defined for any of the builtin
exporters.

The docs also say this specifies a friendly name for the exporter. In
the PR mentioned above, I used the name defined by the entrypoint to key
the exporter. It sounds like maybe we should use the value in
`export_from_notebook` instead, so I've made them match, but perhaps
it's confusing to have a "name" for the entrypoint in two places.
@starcruiseromega

This comment has been minimized.

Copy link
Contributor Author

starcruiseromega commented Aug 25, 2018

@blink1073

This comment has been minimized.

Copy link
Member

blink1073 commented Aug 29, 2018

Thanks!

@blink1073 blink1073 merged commit d084072 into jupyter:master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@starcruiseromega starcruiseromega deleted the starcruiseromega:set_endpoints branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment