New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api break #872

Merged
merged 4 commits into from Sep 1, 2018

Conversation

Projects
None yet
3 participants
@mpacer
Copy link
Member

mpacer commented Aug 31, 2018

Our documentation hasn't built since #814 was merged.

This is because it broke our check_version API which is used by nbsphinx to convert notebooks to sphinx compatible documentation.

This updates that to maintain backwards compatibility (by making it an optional argument) while maintaining the new functionality.

This also adds a test for the expected functionality so we don't break APIs again.

Also this updates the docs on how to build docs and release (and makes it easier to get the doc-building dependencies with a new extra requirements flag in setup.py).

@mpacer

This comment has been minimized.

Copy link
Member Author

mpacer commented Aug 31, 2018

@MSeal we should merge this before releasing.

@MSeal

MSeal approved these changes Aug 31, 2018

Copy link
Contributor

MSeal left a comment

Assuming tests pass :)

@MSeal MSeal merged commit caf130e into jupyter:master Sep 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MSeal MSeal referenced this pull request Sep 1, 2018

Merged

Release 5.4 #869

@mpacer mpacer added this to the 5.4 milestone Sep 4, 2018

@ivanov

This comment has been minimized.

Copy link
Member

ivanov commented Sep 4, 2018

sorry about introducing a breaking change @mpacer - PyCon sprints were a bit of a blur, I had git greped to ensure that function wasn't being used anywhere else in the code base, but I was wrong to not consider others using this API. Thank you for fixing and adding tests so this doesn't happen again.

@t-makaro t-makaro referenced this pull request Sep 23, 2018

Closed

Expose pygments styles #836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment