Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed python 3.4 support, added 3.7 to tests #979

Merged
merged 3 commits into from Apr 5, 2019

Conversation

@MSeal
Copy link
Collaborator

MSeal commented Apr 4, 2019

Discussed in person with @mpacer -- given our several underlying libraries no longer support 3.4 and we see some consistent test failures on PRs with 3.4 we thought removing python 3.4 from nbconvert 5.5 would make sense.

@MSeal MSeal added this to the 5.5 milestone Apr 4, 2019
@MSeal MSeal requested review from Carreau and mpacer Apr 4, 2019
MSeal added 2 commits Apr 4, 2019
@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Apr 4, 2019

huzzah LGTM!

@mpacer

This comment has been minimized.

Copy link
Member

mpacer commented Apr 4, 2019

@Carreau I wanted to hear from you before I merged. But my finger is hovering over the button :D.

@mpacer
mpacer approved these changes Apr 4, 2019
@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Apr 4, 2019

Sounds good !

@Carreau
Carreau approved these changes Apr 4, 2019
@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Apr 4, 2019

Sounds good. If we are moving support for 3.4 do you want to bump the major version number ? I don't see any needs to do that, but it can also be a good time to maybe drop some 3.4 compatibility APIs if we have some.

@MSeal

This comment has been minimized.

Copy link
Collaborator Author

MSeal commented Apr 4, 2019

I was planning on doing a 5.5 release in a week or two -- there's a lot of good work built up. Would you rather it jump to 6.0?

Also totally down to go scrub 3.4 specific branches of code if you know where any are.

@takluyver takluyver merged commit e95597f into jupyter:master Apr 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Copy link
Contributor

Carreau commented Apr 5, 2019

There does not seem to be any 3.4 specific code, so I guess a 5.5 is fine.

Thanks for handling all of that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.