Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Added tests for each branch in execute's run_cell method #982
mpacer left a comment
There are a few places I've made specific suggestions or asked questions that you can address locally to those suggestions/questions.
But the biggest change happening here is the introduction and heavy use of the python
I think the minimal thing would more docstrings for the methods you are introducing that explain (in addition to the usual things parameters, etc.):
Then I think it's worth describing what the architecture is trying to accomplish.
Note on style that may be more meaningful than I would have thought: in general we prefer to use simple
By having tests that look substantially identical to the code that they are running they act as examples of how to use the APIs. As this is currently written, I don't think anyone would be able to work from this to understand how to use these APIs.
Could you try to use any of the idioms from pytest (e.g., fixtures) to make this code better fit the style of the rest of the tests codebase?
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: