Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup kernel death detection #998

Merged
merged 5 commits into from Apr 25, 2019

Conversation

@mpacer
Copy link
Member

mpacer commented Apr 24, 2019

This PR addresses issues that came up in discussion with MSeal around how we're testing kernel deaths (inconsistency between my machine and his + travis' on one test).

This unveiled a broader issue with how we were detecting the death of kernels.

mpacer added 2 commits Apr 24, 2019
This test fails as of this commit.
Adds KernelIsDead as child of RuntimeError
Adds private _is_alive method to raise KernelIsDead.
Previously this was only being checked circuitously in the codepath where the kernel had no timeout.
This should still be abstracted more cleanly but excitedly this works.
This does not address the race condition for the test_startup_kernel_dead case.
@mpacer mpacer requested a review from MSeal Apr 24, 2019
now a new test breaks having to do with the msg not being defined.
This makes the codepath much nicer and easier to follow.
@mpacer mpacer force-pushed the mpacer:fixup_kernel_death_detection branch from fe60c6b to 9012bdf Apr 24, 2019
@@ -24,6 +24,8 @@
from .base import Preprocessor
from ..utils.exceptions import ConversionException

class KernelIsDead(RuntimeError):

This comment has been minimized.

Copy link
@MSeal

MSeal Apr 24, 2019

Collaborator

KernelDied or KernelDiedError

@MSeal
MSeal approved these changes Apr 24, 2019
@MSeal MSeal merged commit abaab8b into jupyter:master Apr 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MSeal MSeal added this to the 5.5 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.