Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add feedback to API #1003
The API call seems to work correctly, but I had some trouble writing a proper test. Relevant error also occurs when testing locally: https://travis-ci.org/jupyter/nbgrader/jobs/416929082#L1363
jhamrick left a comment
For the test, I think rather than adding new files
I would prefer to also not check verbatim the files that are produced by the feedback, as this comparison will fail if anything changes upstream in how nbconvert produces the html. So I think it's sufficient to just check that the files exist rather than comparing them directly (and so you can remove
Let me know if you have any more questions or if you need any help!