New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev requirements and spelling tests #1045

Merged
merged 2 commits into from Dec 15, 2018

Conversation

Projects
None yet
3 participants
@jedbrown
Copy link
Contributor

jedbrown commented Nov 22, 2018

I don't know whether this PR should go to 'master' or '0.5.x'. Should Travis tests be made to regard spelling errors as errors? (It appears that you have to check the logs to see if any errors are identified.)

@jedbrown

This comment has been minimized.

Copy link
Contributor

jedbrown commented Nov 22, 2018

@jedbrown

This comment has been minimized.

Copy link
Contributor

jedbrown commented Nov 22, 2018

Hmm, is the Travis build getting a very old version of pytest that actually needs cov-core? I ran locally with no problems.

@jhamrick

This comment has been minimized.

Copy link
Member

jhamrick commented Dec 15, 2018

Thanks!

The sphinx spellchecker used to cause Travis to error out, but it no longer does. I'm tempted to remove the spell check because it's a bit of a pain and as you pointed out you have to check the logs manually. But that's something to leave for a later PR.

@jhamrick jhamrick merged commit 750f705 into jupyter:master Dec 15, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 7a81a40...bdfb861
Details
codecov/project 88.89% (+0.11%) compared to 7a81a40
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jhamrick jhamrick added the docs label Dec 15, 2018

@jhamrick jhamrick added this to the 0.5.5 milestone Dec 15, 2018

jhamrick added a commit to jhamrick/nbgrader that referenced this pull request Dec 15, 2018

Backport PR jupyter#1049: Update test builds on Travis
- remove cov-core per @jedbrown jupyter#1045
- add more recent python versions
- update to newer travis build parameters

jhamrick added a commit to jhamrick/nbgrader that referenced this pull request Dec 15, 2018

Backport PR jupyter#1045: Dev requirements and spelling tests
I don't know whether this PR should go to 'master' or '0.5.x'. Should Travis tests be made to regard spelling errors as errors? (It appears that you have to check the logs to see if any errors are identified.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment