New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistency in capitalizing Jupyter Notebook #1057

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@jhamrick
Copy link
Member

jhamrick commented Jan 2, 2019

This makes the capitalization of "Jupyter Notebook" more consistent, as per openjournals/jose-reviews#32 (comment) .

Can one of @willingc @dsblank @lgpage @ellisonbg take a second look just to make sure I didn't make a typo somewhere?

cc @jedbrown

@jhamrick jhamrick added the docs label Jan 2, 2019

@jhamrick jhamrick added this to the 0.5.5 milestone Jan 2, 2019

@jhamrick

This comment has been minimized.

Copy link
Member

jhamrick commented Jan 3, 2019

Merging (test failures are unrelated)

@jhamrick jhamrick merged commit a6c99ef into jupyter:master Jan 3, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jhamrick jhamrick deleted the jhamrick:paper-capitalization branch Jan 3, 2019

jhamrick added a commit to jhamrick/nbgrader that referenced this pull request Jan 3, 2019

Backport PR jupyter#1057: Ensure consistency in capitalizing Jupyter …
…Notebook

This makes the capitalization of "Jupyter Notebook" more consistent, as per openjournals/jose-reviews#32 (comment) .

Can one of @willingc @dsblank @lgpage @ellisonbg take a second look just to make sure I didn't make a typo somewhere?

cc @jedbrown
@willingc

This comment has been minimized.

Copy link
Member

willingc commented Jan 4, 2019

@jhamrick This looks good to me. Thanks! Sorry, I've been offline.

jhamrick added a commit that referenced this pull request Jan 6, 2019

Merge pull request #1059 from jhamrick/0.5.x
Backport PR #1057: Ensure consistency in capitalizing Jupyter Notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment